[exporter/awskinesis] do not expose method #27057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakulali
requested review from
Aneurysm9,
MovieStoreGuy and
a team
as code owners
songy23
approved these changes
Sep 21, 2023
evan-bradley
approved these changes
Sep 21, 2023
44 tasks
jorgeancal
pushed a commit
to jorgeancal/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2023
**Description:** Do not export the functions `NewTracesExporter`, `NewMetricsExporter`, `NewLogsExporter` and pass checkapi. **Link to tracking Issue:** open-telemetry#26304 **Testing:** go run cmd/checkapi/main.go . make chlog-validate go test for awskinesisexporter **Documentation:**
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
**Description:** Do not export the functions `NewTracesExporter`, `NewMetricsExporter`, `NewLogsExporter` and pass checkapi. **Link to tracking Issue:** open-telemetry#26304 **Testing:** go run cmd/checkapi/main.go . make chlog-validate go test for awskinesisexporter **Documentation:**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Do not export the functions
NewTracesExporter,NewMetricsExporter,NewLogsExporterand pass checkapi.Link to tracking Issue:
#26304
Testing:
go run cmd/checkapi/main.go .
make chlog-validate
go test for awskinesisexporter
Documentation: