Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/sentry] do not expose method #27054

Merged
merged 13 commits into from
Sep 21, 2023

Conversation

sakulali
Copy link
Contributor

@sakulali sakulali commented Sep 21, 2023

Description:
Do not export the functions CreateSentryExporter and pass checkapi.

Link to tracking Issue:
#26304

Testing:
go run cmd/checkapi/main.go .
make chlog-validate
go test for sentryexporter

Documentation:

@codeboten codeboten merged commit ae2cfaf into open-telemetry:main Sep 21, 2023
92 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 21, 2023
@sakulali sakulali deleted the fix-sentryexporter-api branch September 26, 2023 12:43
jorgeancal pushed a commit to jorgeancal/opentelemetry-collector-contrib that referenced this pull request Oct 9, 2023
Do not export the functions `CreateSentryExporter` and pass checkapi.

open-telemetry#26304

---------

Co-authored-by: Alex Boten <[email protected]>
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
Do not export the functions `CreateSentryExporter` and pass checkapi.

open-telemetry#26304

---------

Co-authored-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants