Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform Example: Change context to datapoint #27041

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Transform Example: Change context to datapoint #27041

merged 4 commits into from
Sep 21, 2023

Conversation

nickv2002
Copy link
Contributor

@nickv2002 nickv2002 commented Sep 21, 2023

Description:

  • Fixing documentation for incorrect transform context.
  • Correcting resource.attributes["k8s_namespace_name" to be correct . separated name.
  • Removing resource.attributes["k8s.cluster.name"] as it's not an available attribute.  

Link to tracking Issue:
#27012 (comment)

Testing:
Works in my own otel-collector.

Documentation:
All documentation updates here.

@nickv2002 nickv2002 requested review from Aneurysm9 and a team as code owners September 21, 2023 01:27
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 21, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Sep 21, 2023
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nickv2002!

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 21, 2023
@TylerHelmuth TylerHelmuth merged commit e54cd41 into open-telemetry:main Sep 21, 2023
98 of 99 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 21, 2023
harishbohara11 pushed a commit to harishbohara11/opentelemetry-collector-contrib that referenced this pull request Sep 21, 2023
)

**Description:** 
- Fixing documentation for incorrect transform context.
- Correcting `resource.attributes["k8s_namespace_name"` to be correct
`.` separated name.
- Removing `resource.attributes["k8s.cluster.name"]` as it's not an
available attribute.  

**Link to tracking Issue:**

open-telemetry#27012 (comment)

**Testing:** 
Works in my own otel-collector.

**Documentation:** 
All documentation updates here.
harishbohara11 added a commit to harishbohara11/opentelemetry-collector-contrib that referenced this pull request Sep 21, 2023
jorgeancal pushed a commit to jorgeancal/opentelemetry-collector-contrib that referenced this pull request Oct 9, 2023
)

**Description:** 
- Fixing documentation for incorrect transform context.
- Correcting `resource.attributes["k8s_namespace_name"` to be correct
`.` separated name.
- Removing `resource.attributes["k8s.cluster.name"]` as it's not an
available attribute.  

**Link to tracking Issue:**

open-telemetry#27012 (comment)

**Testing:** 
Works in my own otel-collector.

**Documentation:** 
All documentation updates here.
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
)

**Description:** 
- Fixing documentation for incorrect transform context.
- Correcting `resource.attributes["k8s_namespace_name"` to be correct
`.` separated name.
- Removing `resource.attributes["k8s.cluster.name"]` as it's not an
available attribute.  

**Link to tracking Issue:**

open-telemetry#27012 (comment)

**Testing:** 
Works in my own otel-collector.

**Documentation:** 
All documentation updates here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/prometheus exporter/prometheusremotewrite ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants