[receiver/statsdreceiver] Gracefully handle empty tagset #27011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatsheep9146
approved these changes
Sep 20, 2023
atoulme
approved these changes
Sep 22, 2023
codeboten
approved these changes
Sep 22, 2023
jorgeancal
pushed a commit
to jorgeancal/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2023
…try#27011) We have a set of client libraries (`com.timgroup.statsd.NonBlockingStatsDClient`) that send a metric like this where there are no tags: ``` some_metric_name:1|c|# ``` Now the validity of this StatsD message can be questioned but the fact of the matter is this is widespread/common behavior for now. This PR includes a fix to move on if no tags in the array are present.
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…try#27011) We have a set of client libraries (`com.timgroup.statsd.NonBlockingStatsDClient`) that send a metric like this where there are no tags: ``` some_metric_name:1|c|# ``` Now the validity of this StatsD message can be questioned but the fact of the matter is this is widespread/common behavior for now. This PR includes a fix to move on if no tags in the array are present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We have a set of client libraries (
com.timgroup.statsd.NonBlockingStatsDClient) that send a metric like this where there are no tags:Now the validity of this StatsD message can be questioned but the fact of the matter is this is widespread/common behavior for now. This PR includes a fix to move on if no tags in the array are present.
Link to tracking Issue:
None
Testing:
Added unit tests
Documentation:
N/A