Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] re-add myself as awsemfexporter codeowner. #27009

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[chore] re-add myself as awsemfexporter codeowner. #27009

merged 1 commit into from
Sep 19, 2023

Conversation

bryan-aguilar
Copy link
Contributor

@bryan-aguilar bryan-aguilar commented Sep 19, 2023 •
edited
Loading

Description: Original merged approval PR: #26100

PR that inadvertantly removed me: #26556

@bryan-aguilar bryan-aguilar requested review from a team and kovrus September 19, 2023 18:54
codeboten
codeboten approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought there would be a failing check if the codeowners file needs to be re-generated, did that not catch this problem?

@bryan-aguilar
Copy link
Contributor Author

@codeboten all checks passed for the PR that had removed me.

@TylerHelmuth TylerHelmuth merged commit 12760ab into open-telemetry:main Sep 19, 2023
92 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 19, 2023
@bryan-aguilar bryan-aguilar deleted the awsemf/readdco branch September 19, 2023 21:00
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
@bryan-aguilar @jmsnll
[chore] re-add myself as awsemfexporter codeowner. (open-telemetry#27009
2eaffab 
)

**Description:** Original merged approval PR:
open-telemetry#26100

PR that inadvertantly removed me:
open-telemetry#26556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@songy23 songy23 songy23 approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@kovrus kovrus Awaiting requested review from kovrus

Assignees

@TylerHelmuth TylerHelmuth

Labels
None yet
Projects
None yet
Milestone
v0.86.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bryan-aguilar @codeboten @songy23 @TylerHelmuth