Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core to latest, fix breaking change in exporter helper Push funcs #2688

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@codecov
Copy link

codecov bot commented Mar 13, 2021

Codecov Report

Merging #2688 (be59e80) into main (047b1d9) will increase coverage by 0.00%.
The diff coverage is 84.07%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2688   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files         439      439           
  Lines       21855    21834   -21     
=======================================
- Hits        19991    19972   -19     
+ Misses       1394     1392    -2     
  Partials      470      470           
Flag Coverage Δ
integration 69.18% <ø> (-0.07%) ⬇️
unit 90.39% <84.07%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/splunkhecexporter/exporter.go 100.00% <ø> (ø)
exporter/jaegerthrifthttpexporter/exporter.go 33.33% <28.57%> (ø)
exporter/datadogexporter/factory.go 82.97% <50.00%> (ø)
exporter/uptraceexporter/exporter.go 88.46% <50.00%> (ø)
exporter/sapmexporter/exporter.go 83.60% <60.00%> (ø)
exporter/carbonexporter/exporter.go 79.62% <66.66%> (ø)
exporter/lokiexporter/exporter.go 94.80% <71.42%> (ø)
exporter/splunkhecexporter/client.go 91.11% <78.57%> (-0.73%) ⬇️
exporter/newrelicexporter/newrelic.go 94.23% <83.33%> (-0.22%) ⬇️
...er/alibabacloudlogserviceexporter/logs_exporter.go 100.00% <100.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 047b1d9...be59e80. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 8c985f8 into open-telemetry:main Mar 15, 2021
@bogdandrutu bogdandrutu deleted the fixreturnint branch March 15, 2021 14:57
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants