Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/splunkenterprise] Additional API metrics #26728

Merged

Conversation

greatestusername
Copy link
Contributor

Description:

  • Adds additional metrics to Splunk Enterprise receiver obtained from API endpoints
  • Updates tests and docs for these additional metrics

Link to tracking Issue: #12667

Testing:

  • Additional tests for new endpoints and metrics added to scraper_test
  • Verify current tests also pass

Documentation:

  • Newly generated docs entries for additional metrics

receiver/splunkenterprisereceiver/scraper.go Outdated Show resolved Hide resolved
receiver/splunkenterprisereceiver/scraper.go Outdated Show resolved Hide resolved
receiver/splunkenterprisereceiver/scraper.go Outdated Show resolved Hide resolved
receiver/splunkenterprisereceiver/scraper.go Outdated Show resolved Hide resolved
receiver/splunkenterprisereceiver/scraper.go Outdated Show resolved Hide resolved
receiver/splunkenterprisereceiver/scraper.go Outdated Show resolved Hide resolved
receiver/splunkenterprisereceiver/scraper.go Outdated Show resolved Hide resolved
receiver/splunkenterprisereceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/splunkenterprisereceiver/scraper.go Outdated Show resolved Hide resolved
receiver/splunkenterprisereceiver/scraper.go Outdated Show resolved Hide resolved
@greatestusername
Copy link
Contributor Author

@atoulme and/or @dmitryax thought I should ping you for an additional review in case I can't get @MovieStoreGuy

Thanks all in advance for looks! <3

@greatestusername
Copy link
Contributor Author

@MovieStoreGuy looking for your eyes/review on this addition of metrics to the Splunk Enterprise receiver. Thanks!!

Copy link
Contributor

@MovieStoreGuy MovieStoreGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great improvement :)

@MovieStoreGuy MovieStoreGuy merged commit 52e2bb8 into open-telemetry:main Sep 29, 2023
92 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 29, 2023
jorgeancal pushed a commit to jorgeancal/opentelemetry-collector-contrib that referenced this pull request Oct 9, 2023
)

**Description:** 
- Adds additional metrics to Splunk Enterprise receiver obtained from
API endpoints
- Updates tests and docs for these additional metrics

**Link to tracking Issue:**
open-telemetry#12667

**Testing:** 
- Additional tests for new endpoints and metrics added to `scraper_test`
- Verify current tests also pass

**Documentation:**
- Newly generated docs entries for additional metrics
@greatestusername greatestusername deleted the splunk-enterprise-metrics branch October 12, 2023 13:53
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
)

**Description:** 
- Adds additional metrics to Splunk Enterprise receiver obtained from
API endpoints
- Updates tests and docs for these additional metrics

**Link to tracking Issue:**
open-telemetry#12667

**Testing:** 
- Additional tests for new endpoints and metrics added to `scraper_test`
- Verify current tests also pass

**Documentation:**
- Newly generated docs entries for additional metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants