-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/splunkenterprise] Additional API metrics #26728
Merged
MovieStoreGuy
merged 25 commits into
open-telemetry:main
from
greatestusername:splunk-enterprise-metrics
Sep 29, 2023
Merged
[receiver/splunkenterprise] Additional API metrics #26728
MovieStoreGuy
merged 25 commits into
open-telemetry:main
from
greatestusername:splunk-enterprise-metrics
Sep 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me/opentelemetry-collector-contrib into splunk-enterprise-metrics
…me/opentelemetry-collector-contrib into splunk-enterprise-metrics
shalper2
reviewed
Sep 19, 2023
…me/opentelemetry-collector-contrib into splunk-enterprise-metrics
…me/opentelemetry-collector-contrib into splunk-enterprise-metrics
shalper2
approved these changes
Sep 19, 2023
@atoulme and/or @dmitryax thought I should ping you for an additional review in case I can't get @MovieStoreGuy Thanks all in advance for looks! <3 |
atoulme
approved these changes
Sep 20, 2023
@MovieStoreGuy looking for your eyes/review on this addition of metrics to the Splunk Enterprise receiver. Thanks!! |
MovieStoreGuy
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a great improvement :)
jorgeancal
pushed a commit
to jorgeancal/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2023
) **Description:** - Adds additional metrics to Splunk Enterprise receiver obtained from API endpoints - Updates tests and docs for these additional metrics **Link to tracking Issue:** open-telemetry#12667 **Testing:** - Additional tests for new endpoints and metrics added to `scraper_test` - Verify current tests also pass **Documentation:** - Newly generated docs entries for additional metrics
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
) **Description:** - Adds additional metrics to Splunk Enterprise receiver obtained from API endpoints - Updates tests and docs for these additional metrics **Link to tracking Issue:** open-telemetry#12667 **Testing:** - Additional tests for new endpoints and metrics added to `scraper_test` - Verify current tests also pass **Documentation:** - Newly generated docs entries for additional metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue: #12667
Testing:
scraper_test
Documentation: