[pkg/ottl] Add new TruncateTime function #26696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested review from
bogdandrutu,
evan-bradley and
a team
as code owners
|
LGTM. I was trying to think of other error cases to test, but time and duration do not really have null values. Maybe we can test a time value before the year 2000? |
|
/cc @evan-bradley |
evan-bradley
approved these changes
Sep 20, 2023
harishbohara11
pushed a commit
to harishbohara11/opentelemetry-collector-contrib
that referenced
this pull request
Sep 21, 2023
harishbohara11
added a commit
to harishbohara11/opentelemetry-collector-contrib
that referenced
this pull request
Sep 21, 2023
This reverts commit 9241696.
jorgeancal
pushed a commit
to jorgeancal/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
To facilitate more time manipulation scenarios, this PR adds a new
TruncateTimefunction that exposes Go'stime.Truncatefunction .Link to tracking Issue:
Related to:
Testing:
Added new unit tests
Documentation:
Updated ottlfunc readme