Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/ottl] ottlarg struct tag cleanup #26669

Merged
merged 2 commits into from
Sep 13, 2023
Merged

[pkg/ottl] ottlarg struct tag cleanup #26669

merged 2 commits into from
Sep 13, 2023

Conversation

TylerHelmuth
Copy link
Member

Description:
Removes all instances of ottlarg. Followup to #25705

Link to tracking Issue:
#24874

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
internal/filter/filterottl/functions.go ø
pkg/ottl/ottlfuncs/func_extract_patterns.go ø
pkg/ottl/ottlfuncs/func_hours.go ø
pkg/ottl/ottlfuncs/func_microseconds.go ø
pkg/ottl/ottlfuncs/func_milliseconds.go ø
pkg/ottl/ottlfuncs/func_minutes.go ø
pkg/ottl/ottlfuncs/func_nanoseconds.go ø
pkg/ottl/ottlfuncs/func_seconds.go ø
pkg/ottl/ottlfuncs/func_unix_micro.go ø
pkg/ottl/ottlfuncs/func_unix_milli.go ø
... and 7 more

📢 Thoughts on this report? Let us know!.

@TylerHelmuth TylerHelmuth merged commit 2a27159 into open-telemetry:main Sep 13, 2023
91 checks passed
@TylerHelmuth TylerHelmuth deleted the ottl-structtag-cleanup branch September 13, 2023 21:03
@github-actions github-actions bot added this to the next release milestone Sep 13, 2023
jorgeancal pushed a commit to jorgeancal/opentelemetry-collector-contrib that referenced this pull request Sep 18, 2023
@TylerHelmuth @jorgeancal
[pkg/ottl] ottlarg struct tag cleanup (open-telemetry#26669)
32e49a3 
**Description:** 
Removes all instances of `ottlarg`. Followup to
open-telemetry#25705

**Link to tracking Issue:** <Issue number if applicable>

open-telemetry#24874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-bradley evan-bradley evan-bradley approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@kentquirk kentquirk Awaiting requested review from kentquirk

Assignees

@djaglowski djaglowski

Labels
internal/filter pkg/ottl processor/transform Transform processor
Projects
None yet
Milestone
v0.86.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TylerHelmuth @evan-bradley @djaglowski