[receiver/kafka] unexport the function WithTracesUnmarshalers, WithMetricsUnmarshalers, WithLogsUnmarshalers
#26644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Sep 12, 2023
crobert-1
approved these changes
Sep 12, 2023
codeboten
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
This looks ok to me, pinging codeowners @pavolloffay @MovieStoreGuy
|
I've filed #27059 for the unit test failure. (Unrelated to this change) |
|
One more ping codeowners @pavolloffay @MovieStoreGuy |
|
Hello @JaredTan95 , it seems need to resolve the conflicts? |
done |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
sakulali
reviewed
Nov 4, 2023
Co-authored-by: sakulali <[email protected]>
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
After resolve the conflicts, i think this PR is ready for merge? |
resolved |
codeboten
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking Issue:
#26304