Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] update core to v0.85.0 #26630

Merged
merged 2 commits into from
Sep 11, 2023
Merged

[chore] update core to v0.85.0 #26630

merged 2 commits into from
Sep 11, 2023

Conversation

codeboten
Copy link
Contributor

For some reason, make update-otel failed for me. Will make a note to add an issue

atoulme
atoulme reviewed Sep 11, 2023
View reviewed changes
cmd/configschema/go.mod
go.opentelemetry.io/collector/extension/auth v0.85.0 // indirect
go.opentelemetry.io/collector/extension/ballastextension v0.85.0 // indirect
go.opentelemetry.io/collector/extension/zpagesextension v0.85.0 // indirect
go.opentelemetry.io/collector/featuregate v1.0.0-rcv0014 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this pulling back to the latest release instead of latest snapshot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand what you mean by snapshot. This is preparing the release of contrib by updating all the deps to the latest released version in core

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The former version was go.opentelemetry.io/collector/featuregate v1.0.0-rcv0014.0.20230908201109-ab3d6c5b6470 (snapshot indicates September 8th) and now is back to go.opentelemetry.io/collector/featuregate v1.0.0-rcv0014 which was released last July. Maybe that doesn't matter, but it's happening for pdata as well, which has this change: open-telemetry/opentelemetry-collector@ebed8dd#diff-1f8826a44b89e0c16a541d21b89589fb86cdbbb6fcdccc976cc6a0e96d0834f7

Maybe that overall doesn't matter? Not sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.0.0-rcv0014 is the latest featuregate/pdata version. We got v1.0.0-rcv0014.0.20230908201109-ab3d6c5b6470 pointing to the latest commit in the core repo when make update-otel runs without a module. So yes, technically, we are rolling back, but since there are no changes in featuregate or pdata, it's ok

@codeboten codeboten mentioned this pull request Sep 11, 2023
Closed
@codeboten codeboten merged commit fb9f011 into open-telemetry:main Sep 11, 2023
91 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 11, 2023
jorgeancal pushed a commit to jorgeancal/opentelemetry-collector-contrib that referenced this pull request Sep 18, 2023
@jorgeancal
[chore] update core to v0.85.0 (open-telemetry#26630)
129bf1c 
For some reason, `make update-otel` failed for me. Will make a note to
add an issue

Signed-off-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme left review comments

@dmitryax dmitryax dmitryax approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@arminru arminru Awaiting requested review from arminru

@songy23 songy23 Awaiting requested review from songy23 songy23 is a code owner

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan tigrannajaryan is a code owner

Assignees

@dashpole dashpole

Labels
cmd/configschema configschema command cmd/githubgen cmd/mdatagen mdatagen command cmd/opampsupervisor cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol cmd/telemetrygen telemetrygen command confmap/provider/s3provider connector/count connector/datadog connector/exceptions connector/routing connector/servicegraph connector/spanmetrics exporter/alibabacloudlogservice Alibaba components exporter/awscloudwatchlogs awscloudwatchlogs exporter exporter/awsemf awsemf exporter exporter/awskinesis exporter/awss3 exporter/awsxray exporter/azuredataexplorer exporter/azuremonitor exporter/carbon exporter/cassandra exporter/clickhouse exporter/coralogix exporter/datadog Datadog components exporter/dataset exporter/dynatrace exporter/elasticsearch exporter/f5cloud F5 exporter exporter/file exporter/googlecloud exporter/googlecloudpubsub exporter/googlemanagedprometheus Google Managed Prometheus exporter exporter/influxdb exporter/instana exporter/jaeger exporter/jaegerthrifthttp exporter/kafka exporter/loadbalancing exporter/logicmonitor exporter/logzio exporter/loki Loki Exporter exporter/mezmo exporter/opencensus exporter/opensearch exporter/parquet exporter/prometheus
Projects
None yet
Milestone
v0.85.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codeboten @atoulme @dmitryax @dashpole