Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/probabilisticsampler] Allow non-bytes attributes #26564

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

jpkrohling
Copy link
Member

When doing a probabilistic sampling for logs, the probabilistic sampler currently requires the source attribute to be of bytes value. This PR changes that to allow any value type to be used.

Fixes #18222

Signed-off-by: Juraci Paixão Kröhling [email protected]

When doing a probabilistic sampling for logs, the probabilistic sampler currently requires the source attribute to be of bytes value. This PR changes that to allow any value type to be used.

Fixes #18222

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling jpkrohling requested a review from a team as a code owner September 11, 2023 14:23
@github-actions github-actions bot added the processor/probabilisticsampler Probabilistic Sampler processor label Sep 11, 2023
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 26, 2023
@github-actions github-actions bot removed the Stale label Sep 29, 2023
@dashpole dashpole added the ready to merge Code review completed; ready to merge by maintainers label Oct 2, 2023
@codeboten codeboten merged commit 7b9a79b into open-telemetry:main Oct 4, 2023
96 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 4, 2023
sumo-drosiek pushed a commit to sumo-drosiek/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2023
…emetry#26564)

When doing a probabilistic sampling for logs, the probabilistic sampler
currently requires the source attribute to be of bytes value. This PR
changes that to allow any value type to be used.

Fixes open-telemetry#18222

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

---------

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jorgeancal pushed a commit to jorgeancal/opentelemetry-collector-contrib that referenced this pull request Oct 9, 2023
…emetry#26564)

When doing a probabilistic sampling for logs, the probabilistic sampler
currently requires the source attribute to be of bytes value. This PR
changes that to allow any value type to be used.

Fixes open-telemetry#18222

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

---------

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…emetry#26564)

When doing a probabilistic sampling for logs, the probabilistic sampler
currently requires the source attribute to be of bytes value. This PR
changes that to allow any value type to be used.

Fixes open-telemetry#18222

Signed-off-by: Juraci Paixão Kröhling <[email protected]>

---------

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/probabilisticsampler Probabilistic Sampler processor ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[processor/probabilisticsampler] panics when non-Bytes log attribute chosen
6 participants