Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/hostmetrics] make sure process scraper uses root_path config entry #26479

Merged
merged 7 commits into from
Sep 22, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Sep 5, 2023

Description:
A regression introduced in 0.82.0 means that the process scraper doesn't properly respect the root_path configuration key when it comes to reading process information.

Link to tracking Issue:
Fixes #24777

Testing:
Unit tests fixes and new end to end tests.

Documentation:
N/A

@atoulme atoulme requested review from dmitryax and a team as code owners September 5, 2023 23:13
@atoulme atoulme force-pushed the use_context_in_process_scraper branch 4 times, most recently from 234f912 to 3834140 Compare September 6, 2023 04:33
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atoulme please rebase

receiver/hostmetricsreceiver/e2e_test.go Outdated Show resolved Hide resolved
@dmitryax dmitryax added the Run Windows Enable running windows test on a PR label Sep 11, 2023
@atoulme atoulme force-pushed the use_context_in_process_scraper branch from 3834140 to fd0d4f4 Compare September 12, 2023 17:37
@dmitryax
Copy link
Member

@atoulme please rebase

@atoulme atoulme force-pushed the use_context_in_process_scraper branch from d09811b to a251260 Compare September 14, 2023 06:11
@atoulme
Copy link
Contributor Author

atoulme commented Sep 21, 2023

@dmitryax ready for you I think?

receiver/hostmetricsreceiver/go.mod Outdated Show resolved Hide resolved
@atoulme atoulme force-pushed the use_context_in_process_scraper branch from 95af9fa to b0e298f Compare September 22, 2023 06:09
@dmitryax dmitryax merged commit 8d0ca3d into open-telemetry:main Sep 22, 2023
100 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 22, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…g entry (open-telemetry#26479)

**Description:**
A regression introduced in 0.82.0 means that the process scraper doesn't
properly respect the `root_path` configuration key when it comes to
reading process information.

**Link to tracking Issue:**
Fixes open-telemetry#24777 

---------

Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/hostmetrics Run Windows Enable running windows test on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/hostmetrics] Process scraper ignores root_path when getting process information
3 participants