Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/alibabacloudlogservice] do not expose method #26383

Merged
merged 3 commits into from
Sep 5, 2023
Merged

[exporter/alibabacloudlogservice] do not expose method #26383

merged 3 commits into from
Sep 5, 2023

Conversation

sakulali
Copy link
Contributor

@sakulali sakulali commented Sep 4, 2023

Description:
Remove exposed function, only keep NewFactory to pass checkapi

Link to tracking Issue:
#26304

@sakulali sakulali requested a review from a team as a code owner September 4, 2023 13:52
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 4, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the exporter/alibabacloudlogservice Alibaba components label Sep 4, 2023
mx-psi
mx-psi reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog entry, you can use https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/ca3ebe7157ef46b9c4ba6c76121b91b8b0673b4b/.chloggen/awss3-checkapi.yaml as an example to see how to fill in the fields

@sakulali sakulali changed the title Fix alibabacloudlogserviceexporter api [chore] update alibabacloudlogserviceexporter to pass apicheck Sep 4, 2023
@sakulali sakulali changed the title [chore] update alibabacloudlogserviceexporter to pass apicheck [exporter/alibabacloudlogservice] do not expose method Sep 4, 2023
crobert-1
crobert-1 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need changelog as requested, changes look good otherwise.

@sakulali
Copy link
Contributor Author

sakulali commented Sep 5, 2023

Needs a changelog entry, you can use https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/ca3ebe7157ef46b9c4ba6c76121b91b8b0673b4b/.chloggen/awss3-checkapi.yaml as an example to see how to fill in the fields
Thanks for the recommendation! I've updated the PR

@sakulali sakulali closed this Sep 5, 2023
@sakulali sakulali reopened this Sep 5, 2023
@sakulali
Copy link
Contributor Author

sakulali commented Sep 5, 2023

Needs a changelog entry, you can use https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/ca3ebe7157ef46b9c4ba6c76121b91b8b0673b4b/.chloggen/awss3-checkapi.yaml as an example to see how to fill in the fields

Thanks for the recommendation! I've updated the PR

@sakulali
Copy link
Contributor Author

sakulali commented Sep 5, 2023

Need changelog as requested, changes look good otherwise.

Thank you for the review! Done

@mx-psi mx-psi merged commit f94a24d into open-telemetry:main Sep 5, 2023
93 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 5, 2023
@sakulali sakulali deleted the fix-alibabacloudlogserviceexporter-api branch September 26, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@crobert-1 crobert-1 crobert-1 approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@kongluoxing kongluoxing Awaiting requested review from kongluoxing

@qiansheng91 qiansheng91 Awaiting requested review from qiansheng91

@shabicheng shabicheng Awaiting requested review from shabicheng

Assignees

@mx-psi mx-psi

Labels
exporter/alibabacloudlogservice Alibaba components
Projects
None yet
Milestone
v0.85.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sakulali @mx-psi @crobert-1