[pkg/ottl] Cleanup OTTL Time/Duration #26364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
added
the
Skip Changelog
TylerHelmuth
requested review from
bogdandrutu,
evan-bradley and
a team
as code owners
crobert-1
approved these changes
Aug 31, 2023
|
Kubernetes test failure is frequency of #24223. Both test failures are unrelated to this change. |
TylerHelmuth
force-pushed
the
update-ottl-funcs
branch
from
1d5e202
to
b5666a7
Compare
TylerHelmuth
changed the title
TylerHelmuth
changed the title
Co-authored-by: Curtis Robert <[email protected]>
evan-bradley
approved these changes
Sep 1, 2023
TylerHelmuth
added
the
ready to merge
This was referenced Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently missed that func docs were missing when I merged some new functions. Also updated some godoc typos and renamed some function files to match our naming pattern.