Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s.io/client-go from 0.27.4 to 0.28.1 in /internal/kubelet #26156

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 28, 2023

Bumps k8s.io/client-go from 0.27.4 to 0.28.1.

Commits
  • dd6c552 Update dependencies to v0.28.1 tag
  • fe76ecc Merge remote-tracking branch 'origin/master' into release-1.28
  • a715d8b Merge pull request #119876 from marosset/revert-118895
  • 3163e5a Revert "Merge pull request #118895 from RyanAoh/kep-1860"
  • 8d766e7 Avoid returning nil responseKind in v1beta1 aggregated discovery
  • dcfe307 Merge remote-tracking branch 'origin/master' into release-1.28
  • 7d2c3df .*: bump golang.org/x/net to v0.13.0
  • c5b1c13 Merge pull request #118644 from alexzielenski/apiserver/policy/namespaceParamRef
  • a98e74a Merge pull request #116469 from RomanBednar/pv-phase-transition-time
  • dcfedbe make update
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.27.4 to 0.28.1.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.27.4...v0.28.1)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested review from dmitryax and a team as code owners August 28, 2023 18:16
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Aug 28, 2023
@dmitryax
Copy link
Member

Blocked by #26024

@dmitryax dmitryax closed this Aug 28, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 28, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/internal/kubelet/k8s.io/client-go-0.28.1 branch August 28, 2023 18:21
dmitryax pushed a commit that referenced this pull request Aug 28, 2023
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
There was a breaking change in this upgrade that needed to be handled
manually. The fix is to replace usages of ConfigMapsLeasesResourceLock
with LeasesResourceLock.

To do the deps updates I did the following:
``` 
cd internal/aws/k8s/
go get -u k8s.io/[email protected]
cd ../../kubelet/
go get -u k8s.io/[email protected]
```
These directories correspond to the two PRs that were closed because of
the original issue.
Original PRs: #26010, and #26156.

This doesn't update all packages to use v0.28.1, so let me know if I
should update to include all others as well.

**Link to tracking Issue:** <Issue number if applicable>
Fixes #26024

**Testing:** <Describe what testing was performed and which tests were
added.>
Build completes successfully now

**Documentation:** <Describe the documentation added.>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant