Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contrib with latest from core #257

Conversation

ccaraman
Copy link
Contributor

Description: Pulls in he latest core changes including TLS Config refactor.

@ccaraman ccaraman requested a review from a team as a code owner May 22, 2020 17:48
@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #257 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   78.09%   78.13%   +0.04%     
==========================================
  Files         128      128              
  Lines        6697     6697              
==========================================
+ Hits         5230     5233       +3     
+ Misses       1175     1173       -2     
+ Partials      292      291       -1     
Impacted Files Coverage Δ
receiver/carbonreceiver/transport/tcp_server.go 68.57% <0.00%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2741f33...eda4582. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit a1020fa into open-telemetry:master May 22, 2020
wyTrivail referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 13, 2020
Pulls in he latest core changes including TLS Config refactor.
mxiamxia referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 22, 2020
- Problem to solve: Logging exporter outputs received
      traces/metrics to the stdout. The existing implementation
      uses the same log level as the otel process. So if the otel
      process uses info log level, the user can not  see more verbose
      logging message via the logging exporter on the console.
- Solution: use sperate zap loggers for exporters used in different
      pipelines.
- Use case: (1) as describe above.(2) Later more log messages
      could be added to the logging_exporter.go in different
      log levels, which could be configurable. (3) Setting
      different log levels for loggers in different pipelines.

  process. With this approach, users can configures the log level
  of the logging exporter. In additon, messages in the exporter
  could appear according to the level in the configuration
  file.

Co-Authored-By: Yang Song <[email protected]>
Signed-off-by: Hui Kang <[email protected]>
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants