[chore] [internal/aws] Change TestMapWithExpiry to explicitly test cleanup #25097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
reviewed
Aug 8, 2023
| @@ -130,14 +139,14 @@ func TestMapWithExpiryCleanup(t *testing.T) { | |||
| assert.Equal(t, 1, store.Size()) | |||
| store.Unlock() | |||
|
|
|||
| time.Sleep(time.Second + time.Millisecond) | |||
| time.Sleep(time.Second * 2) | |||
There was a problem hiding this comment.
This is a significant increase. Why is this needed?
There was a problem hiding this comment.
There's actually no need. I reduced it even further by dropping the TTL and the sleep time together.
dmitryax
approved these changes
Aug 8, 2023
Aneurysm9
approved these changes
Aug 8, 2023
| @@ -130,14 +139,14 @@ func TestMapWithExpiryCleanup(t *testing.T) { | |||
| assert.Equal(t, 1, store.Size()) | |||
| store.Unlock() | |||
|
|
|||
| time.Sleep(time.Second + time.Millisecond) | |||
| time.Sleep(time.Millisecond * 2) | |||
There was a problem hiding this comment.
Is there ever a chance that time.Now() can return the same value? If so that would put a requirement for the sleep.
dmitryax
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Changes the behavior of the specific test case to be more aligned with its behavior pre #25066
Link to tracking Issue: #25095