Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] close http responses and preallocate slices #24926

Merged
merged 5 commits into from
Sep 22, 2023
Merged

[chore] close http responses and preallocate slices #24926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aea661d
[chore] close http responses and preallocate slices
atoulme Aug 5, 2023
6927e1a
Merge branch 'main' into signalfx_receiver_tests
atoulme Aug 6, 2023
b47a145
Merge branch 'main' into signalfx_receiver_tests
atoulme Aug 11, 2023
db9e782
use append style
atoulme Aug 18, 2023
5a15866
Update receiver/signalfxreceiver/receiver_test.go
atoulme Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions receiver/signalfxreceiver/receiver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,7 @@ func Test_sfxReceiver_handleReq(t *testing.T) {

resp := w.Result()
respBytes, err := io.ReadAll(resp.Body)
defer resp.Body.Close()
assert.NoError(t, err)

var bodyStr string
Expand Down Expand Up @@ -521,6 +522,7 @@ func Test_sfxReceiver_handleEventReq(t *testing.T) {
resp := w.Result()
respBytes, err := io.ReadAll(resp.Body)
assert.NoError(t, err)
defer resp.Body.Close()

var bodyStr string
assert.NoError(t, json.Unmarshal(respBytes, &bodyStr))
Expand Down Expand Up @@ -600,6 +602,7 @@ func Test_sfxReceiver_TLS(t *testing.T) {

resp, err := client.Do(req)
require.NoErrorf(t, err, "should not have failed when sending to signalFx receiver %v", err)
defer resp.Body.Close()
assert.Equal(t, http.StatusOK, resp.StatusCode)
t.Log("SignalFx Request Received")

Expand Down Expand Up @@ -664,6 +667,7 @@ func Test_sfxReceiver_DatapointAccessTokenPassthrough(t *testing.T) {
resp := w.Result()
respBytes, err := io.ReadAll(resp.Body)
assert.NoError(t, err)
defer resp.Body.Close()

var bodyStr string
assert.NoError(t, json.Unmarshal(respBytes, &bodyStr))
Expand Down Expand Up @@ -742,6 +746,7 @@ func Test_sfxReceiver_EventAccessTokenPassthrough(t *testing.T) {
resp := w.Result()
respBytes, err := io.ReadAll(resp.Body)
assert.NoError(t, err)
defer resp.Body.Close()

var bodyStr string
assert.NoError(t, json.Unmarshal(respBytes, &bodyStr))
Expand Down
2 changes: 1 addition & 1 deletion receiver/signalfxreceiver/signalfxv2_event_to_logdata_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func TestSignalFxV2EventsToLogData(t *testing.T) {
}

func mapToEventProps(m map[string]interface{}) []*sfxpb.Property {
var out []*sfxpb.Property
out := make([]*sfxpb.Property, 0, len(m))
for k, v := range m {
var pval sfxpb.PropertyValue

Expand Down