Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/skywalkingreceiver] Unexport MockGrpcTraceSegment #24877

Merged
merged 2 commits into from
Aug 4, 2023
Merged

[receiver/skywalkingreceiver] Unexport MockGrpcTraceSegment #24877

merged 2 commits into from
Aug 4, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Aug 3, 2023

No description provided.

@atoulme atoulme requested a review from a team as a code owner August 3, 2023 23:51
@atoulme atoulme force-pushed the unexport_skywalkingreceiver branch from 8c485fe to 41ba201 Compare August 3, 2023 23:51
JaredTan95
JaredTan95 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@JaredTan95 JaredTan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoulme atoulme added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 4, 2023
@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Aug 4, 2023
@TylerHelmuth TylerHelmuth merged commit 0c2d590 into open-telemetry:main Aug 4, 2023
98 of 99 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@JaredTan95 JaredTan95 JaredTan95 approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@codeboten codeboten

Labels
ready to merge Code review completed; ready to merge by maintainers receiver/skywalking Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.83.0
Development

Successfully merging this pull request may close these issues.
5 participants
@atoulme @songy23 @TylerHelmuth @JaredTan95 @codeboten