[exporter/awsxray] Fix X-Ray metadata unmarshal. #24804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5991378
to
95e4e74
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
95e4e74
to
b84042e
Compare
abef923
to
7b38c4d
Compare
srprash
approved these changes
Sep 19, 2023
7b38c4d
to
7e6dde9
Compare
bryan-aguilar
approved these changes
Sep 20, 2023
Aneurysm9
approved these changes
Sep 20, 2023
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
|
@jefchien looks like codecov is going to fail as the project targeted percentage is below the 85% limit. |
7e6dde9
to
75f0d34
Compare
|
@bryan-aguilar Not really sure how to improve that. The changes are fully covered by the added unit test. |
75f0d34
to
758a0de
Compare
758a0de
to
d7bc17b
Compare
codeboten
approved these changes
Sep 21, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
**Description:** The X-Ray receiver [marshals the metadata](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/awsxrayreceiver/internal/translator/metadata.go#L16) from the X-Ray SDK, but the exporter doesn't unmarshal the metadata, which results in squashed and incorrectly nested metadata. ``` "metadata": { "default": { "aws.xray.metadata.http": "{\"connection\":{\"reused\":false,\"was_idle\":false}}" } }, ``` instead of ``` "metadata": { "http": { "connection": { "was_idle": false, "reused": false } } }, ``` Changes the exporter translator to check for the metadata attribute prefix and attempt to unmarshal those. **Link to tracking Issue:** open-telemetry#23610 **Testing:** Added unit test. Ran the change with the collector and verified in the AWS X-Ray console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The X-Ray receiver marshals the metadata from the X-Ray SDK, but the exporter doesn't unmarshal the metadata, which results in squashed and incorrectly nested metadata.
instead of
Changes the exporter translator to check for the metadata attribute prefix and attempt to unmarshal those.
Link to tracking Issue: #23610
Testing: Added unit test. Ran the change with the collector and verified in the AWS X-Ray console.