[datadog receiver] Exit function on failed payload decode #24658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
approved these changes
Jul 28, 2023
jpkrohling
approved these changes
Jul 28, 2023
| @@ -91,6 +91,7 @@ func (ddr *datadogReceiver) handleTraces(w http.ResponseWriter, req *http.Reques | |||
| if err != nil { | |||
| http.Error(w, "Unable to unmarshal reqs", http.StatusInternalServerError) | |||
| ddr.params.Logger.Error("Unable to unmarshal reqs") | |||
| return | |||
There was a problem hiding this comment.
Do you think it's feasible to add a test for this?
There was a problem hiding this comment.
Yeah, sorry it too me a bit to figure out how best to test it.
crobert-1
approved these changes
Jul 28, 2023
MovieStoreGuy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Exit on error to avoid NPE
Link to tracking Issue:
Fixes #24562
Testing:
I would like to fix up how the component does tests in future PR.
Documentation:
N/A