[chronyreceiver] Remove hard dependency on explicit timeout #24652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MovieStoreGuy
added
the
Skip Changelog
atoulme
changed the title
|
@jamesmoessis please review when you get a chance as codeowner, thanks! |
jamesmoessis
approved these changes
Aug 3, 2023
atoulme
added
the
ready to merge
atoulme
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With the upcoming changes in open-telemetry/opentelemetry-collector#7951 where it includes timeout as an explicit field, chrony receiver is no longer required to explicitly call it.
Link to tracking Issue:
NA
Testing:
Updated tests where required
Documentation:
Documentation remains the same.