Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] update CONTRIBUTING to match codeowners generation step #24556

Merged
merged 5 commits into from
Jul 28, 2023
Merged

[chore] update CONTRIBUTING to match codeowners generation step #24556

merged 5 commits into from
Jul 28, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jul 26, 2023

Fixes #23367

This is the last PR to move to a generated CODEOWNERS file managed via metadata.

@atoulme atoulme requested a review from a team as a code owner July 26, 2023 01:20
@atoulme atoulme requested a review from jpkrohling July 26, 2023 01:20
@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Jul 26, 2023
@TylerHelmuth
Copy link
Member

@atoulme created #24574 to merge the 2 make commands into 1 step.

jpkrohling
jpkrohling reviewed Jul 27, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
atoulme and others added 2 commits July 27, 2023 11:02
@atoulme
Copy link
Contributor Author

atoulme commented Jul 27, 2023 •
edited
Loading

@atoulme created #24574 to merge the 2 make commands into 1 step.

I should update the doc to use your command then. Done

atoulme
atoulme commented Jul 27, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
atoulme
atoulme commented Jul 27, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@jpkrohling jpkrohling merged commit d3086c7 into open-telemetry:main Jul 28, 2023
89 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees

@TylerHelmuth TylerHelmuth

Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
v0.82.0
Development

Successfully merging this pull request may close these issues.

Move codeowners to status metadata
4 participants
@atoulme @TylerHelmuth @jpkrohling @songy23