[chore] [processor/resourcedetection] Create ResourceBuilder on start #24437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create ResourceBuilder during the initialization state, not in the Detect call. We want to make sure that ResourceBuilder is initialized only once so we can introduce the same warnings as MetricsBuilder has. Detect is currently called only once as well, but it's better to not depend on such behavior, so it can be changed independently in future if needed.
4a75072
to
0604716
Compare
atoulme
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create ResourceBuilder during the initialization state, not in the Detect call. We want to make sure that ResourceBuilder is initialized only once so we can introduce the same warnings as MetricsBuilder has. Detect is currently called only once as well, but it's better not to depend on such behavior, so it can be changed independently in the future if needed.