Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ottl len converter #24420

Merged
merged 6 commits into from
Jul 27, 2023
Merged

Add ottl len converter #24420

merged 6 commits into from
Jul 27, 2023

Conversation

jack-berg
Copy link
Member

Description:

Add ottl Len converter to make Substring useful for truncating. E.g.:

    log_statements:
      - context: log
        statements:
        - set(body, Substring(body, 0, 10)) where Len(body) >= 10

Link to tracking Issue: Resolves #23847.

Testing: Unit tests, local verification with running collector.

Documentation: Added documentation to pkg/ottl/ottlfuncs/README.md.

This PR is the result of conversation on #23880.

@jack-berg jack-berg mentioned this pull request Jul 20, 2023
Closed
@github-actions github-actions bot requested a review from kentquirk July 20, 2023 21:40
TylerHelmuth
TylerHelmuth reviewed Jul 21, 2023
View reviewed changes
.chloggen/add-ottl-len-converter.yaml Outdated Show resolved Hide resolved
pkg/ottl/ottlfuncs/func_len.go Outdated Show resolved Hide resolved
TylerHelmuth
TylerHelmuth approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pkg/ottl/ottlfuncs/func_len.go Outdated Show resolved Hide resolved
pkg/ottl/ottlfuncs/func_len.go Outdated Show resolved Hide resolved
.chloggen/add-ottl-len-converter.yaml Outdated Show resolved Hide resolved
pkg/ottl/ottlfuncs/README.md Outdated Show resolved Hide resolved
pkg/ottl/ottlfuncs/README.md Outdated Show resolved Hide resolved
@TylerHelmuth
Copy link
Member

@jack-berg I got the spacing wrong :(

evan-bradley
evan-bradley approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for implementing this.

pkg/ottl/ottlfuncs/func_len_test.go Outdated Show resolved Hide resolved
@TylerHelmuth TylerHelmuth merged commit 3e1037a into open-telemetry:main Jul 27, 2023
89 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 27, 2023
@markdingram markdingram mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-bradley evan-bradley evan-bradley approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@kentquirk kentquirk Awaiting requested review from kentquirk

Assignees

@fatsheep9146 fatsheep9146

Labels
pkg/ottl
Projects
None yet
Milestone
v0.82.0
Development

Successfully merging this pull request may close these issues.

[processor/transform] not enough preconditions to guard against warnings
4 participants
@jack-berg @TylerHelmuth @evan-bradley @fatsheep9146