Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [exporter/datadog] Refactor host metadata in terms of a pusher #24271

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jul 14, 2023

Description:

Refactors current host metadata logic in preparation for using inframetadata.Reporter.

This is an internal-only change with no user-facing consequences

@github-actions github-actions bot added the exporter/datadog Datadog components label Jul 14, 2023
@mx-psi mx-psi marked this pull request as ready for review July 14, 2023 15:39
@mx-psi mx-psi requested a review from a team as a code owner July 14, 2023 15:39
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs make gotidy

@mx-psi mx-psi requested a review from dmitryax as a code owner July 17, 2023 10:33
@mx-psi mx-psi requested a review from songy23 July 17, 2023 10:33
@github-actions github-actions bot added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command labels Jul 17, 2023
@github-actions github-actions bot requested a review from pmcollins July 17, 2023 10:33
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mx-psi mx-psi merged commit f0ba02b into open-telemetry:main Jul 17, 2023
89 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 17, 2023
mx-psi added a commit that referenced this pull request Jul 19, 2023
**Description:** 

Enables `inframetadata.Reporter`. This allows sending host metadata
based on resource payloads that have the boolean
`datadog.host.use_as_metadata` set to `true`.

By default, host metadata payloads will not be sent by default.

Depends on #24271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command exporter/datadog Datadog components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants