Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/k8scluster] Change k8s.replicaset metrics to use mdatagen #24254

Merged

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Jul 13, 2023

Description: Change k8s.replicaset metrics to use mdatagen

The migration has the following side effects, we add scope and schema to metrics:

    schemaUrl: "https://opentelemetry.io/schemas/1.18.0"
...
        scope:
          name: otelcol/k8sclusterreceiver
          version: latest

Link to tracking Issue:
#10553
#4367

Testing:

  • Updated unit tests

Documentation:

  • Generated docs

@dmitryax
Copy link
Member

@povilasv isn't this one ready?

@povilasv
Copy link
Contributor Author

@povilasv isn't this one ready?

Not yet, I am investigating why E2E tests are failing https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5542796872/jobs/10118157279?pr=24254

@povilasv povilasv force-pushed the k8s-cluster-receiver-replicaset branch 2 times, most recently from 9c43aaf to f710d05 Compare July 20, 2023 10:55
@povilasv povilasv force-pushed the k8s-cluster-receiver-replicaset branch from f710d05 to e4cefe1 Compare July 20, 2023 11:16
@povilasv povilasv marked this pull request as ready for review July 20, 2023 11:34
@povilasv povilasv requested a review from a team as a code owner July 20, 2023 11:34
@povilasv povilasv requested a review from crobert-1 July 20, 2023 11:34
@povilasv
Copy link
Contributor Author

povilasv commented Jul 20, 2023

Hey, @dmitryax and @crobert-1 this is ready for another round of review :)

Found the issue with CI.

FYI: The migration has the following side effects, we add scope and schema to metrics:

    schemaUrl: "https://opentelemetry.io/schemas/1.18.0"
...
        scope:
          name: otelcol/k8sclusterreceiver
          version: latest

@dmitryax dmitryax merged commit ca2bc25 into open-telemetry:main Jul 20, 2023
91 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 20, 2023
@povilasv povilasv deleted the k8s-cluster-receiver-replicaset branch July 20, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants