Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add boolean behavior for time objects #24243

Merged
merged 6 commits into from
Jul 14, 2023

Conversation

fchikwekwe
Copy link
Contributor

@fchikwekwe fchikwekwe commented Jul 12, 2023

Description: Allows time comparison by enabling boolean behavior for time objects.

Link to tracking Issue: Closes #22008

Testing: Unit tests

Documentation:

pkg/ottl/compare.go Outdated Show resolved Hide resolved
pkg/ottl/compare.go Outdated Show resolved Hide resolved
pkg/ottl/boolean_value_test.go Outdated Show resolved Hide resolved
pkg/ottl/boolean_value_test.go Show resolved Hide resolved
pkg/ottl/compare.go Outdated Show resolved Hide resolved
pkg/ottl/compare.go Outdated Show resolved Hide resolved
@TylerHelmuth TylerHelmuth merged commit 983815c into open-telemetry:main Jul 14, 2023
89 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pkg/ottl] Boolean expressions are update to be able to handle comparing time.Time types
3 participants