[exporter/datadog] Run source providers in parallel #24234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
reviewed
Jul 12, 2023
exporter/datadogexporter/internal/hostmetadata/provider/provider.go
Outdated
Show resolved
Hide resolved
exporter/datadogexporter/internal/hostmetadata/provider/provider.go
Outdated
Show resolved
Hide resolved
gbbr
reviewed
Jul 12, 2023
exporter/datadogexporter/internal/hostmetadata/provider/provider.go
Outdated
Show resolved
Hide resolved
gbbr
approved these changes
Jul 12, 2023
mx-psi
added
the
ready to merge
songy23
approved these changes
Jul 12, 2023
Co-authored-by: Yang Song <[email protected]>
fyuan1316
pushed a commit
to fyuan1316/opentelemetry-collector-contrib
that referenced
this pull request
Jul 13, 2023
…4234) Make Datadog exporter source providers run in parallel to reduce start times. With the new `Chain` implementation, we start checking all sources in parallel instead of waiting for the previous one to fail. This makes the Datadog exporter call all cloud provider endpoints in all cloud providers, so it may increase spurious logs such as those reported in open-telemetry#24072. **Link to tracking Issue:** Updates open-telemetry#16442 (at least it should substantially improve start time in some environments) --------- Co-authored-by: Yang Song <[email protected]> Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Make Datadog exporter source providers run in parallel to reduce start times. With the new
Chainimplementation, we start checking all sources in parallel instead of waiting for the previous one to fail. This makes the Datadog exporter call all cloud provider endpoints in all cloud providers, so it may increase spurious logs such as those reported in #24072.Link to tracking Issue: Updates #16442 (at least it should substantially improve start time in some environments)
Testing: Added unit test
Documentation: Performance improvement, no new docs needed