Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal/components] register jaegerremotesampling extension #24212

Merged
merged 1 commit into from
Jul 20, 2023
Merged

[internal/components] register jaegerremotesampling extension #24212

merged 1 commit into from
Jul 20, 2023

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented Jul 11, 2023

Description:

Register jaegerremotesampling extension

Link to tracking Issue:

Testing:

Documentation:

@frzifus frzifus requested a review from a team as a code owner July 11, 2023 20:52
@frzifus frzifus added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 11, 2023
@frzifus frzifus requested a review from jpkrohling July 11, 2023 20:52
@frzifus frzifus force-pushed the register_jaegerremotesampling_extension branch from 5c9c080 to a2a06da Compare July 11, 2023 21:14
@atoulme
Copy link
Contributor

atoulme commented Jul 16, 2023

Please run make crosslink

@frzifus frzifus force-pushed the register_jaegerremotesampling_extension branch from 70a8b3e to 5d25fca Compare July 16, 2023 12:19
@frzifus frzifus force-pushed the register_jaegerremotesampling_extension branch from 5d25fca to 85f550f Compare July 16, 2023 12:19
@github-actions github-actions bot added the cmd/configschema configschema command label Jul 16, 2023
@github-actions github-actions bot requested a review from pmcollins July 16, 2023 12:19
@frzifus
Copy link
Member Author

frzifus commented Jul 16, 2023

done 👍

@frzifus frzifus force-pushed the register_jaegerremotesampling_extension branch from 85f550f to a87414e Compare July 17, 2023 13:36
@jpkrohling
Copy link
Member

jpkrohling commented Jul 17, 2023 •
edited
Loading

The build failed with:

go.mod/go.sum deps changes detected, please run "make gotidy" and commit the changes in this PR.

@frzifus frzifus force-pushed the register_jaegerremotesampling_extension branch from a87414e to 7f0a266 Compare July 17, 2023 22:36
@jpkrohling
Copy link
Member

Looks like it's still failing:

make[1]: Leaving directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib'
diff --git a/go.mod b/go.mod
index c01ef5f..c9940cb 100644
--- a/go.mod
+++ b/go.mod
@@ -168,7 +168,6 @@ require (
 	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/windowsperfcountersreceiver v0.81.0
 	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/zipkinreceiver v0.81.0
 	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/zookeeperreceiver v0.81.0
-	github.com/prometheus/client_golang v1.16.0
 	go.opentelemetry.io/collector v0.81.0
 	go.opentelemetry.io/collector/exporter v0.81.0
 	go.opentelemetry.io/collector/exporter/loggingexporter v0.81.0
@@ -542,6 +541,7 @@ require (
 	github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
 	github.com/power-devops/perfstat v0.0.0-20220216144756-c35f1ee13d7c // indirect
 	github.com/pquerna/cachecontrol v0.1.0 // indirect
+	github.com/prometheus/client_golang v1.16.0 // indirect
 	github.com/prometheus/client_model v0.4.0 // indirect
 	github.com/prometheus/common v0.44.0 // indirect
 	github.com/prometheus/common/sigv4 v0.1.0 // indirect
go.mod/go.sum deps changes detected, please run "make gotidy" and commit the changes in this PR.

@frzifus frzifus force-pushed the register_jaegerremotesampling_extension branch from 7f0a266 to 65cad8c Compare July 18, 2023 08:46
@frzifus
Copy link
Member Author

frzifus commented Jul 18, 2023

hm.. seems that was caused by a local unstaged file. :/

@jpkrohling jpkrohling merged commit acaa2b8 into open-telemetry:main Jul 20, 2023
89 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 left review comments

@jpkrohling jpkrohling jpkrohling approved these changes

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@mx-psi mx-psi Awaiting requested review from mx-psi

@dmitryax dmitryax Awaiting requested review from dmitryax

@pmcollins pmcollins Awaiting requested review from pmcollins

Assignees

@atoulme atoulme

Labels
cmd/configschema configschema command cmd/oteltestbedcol Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.82.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@frzifus @atoulme @jpkrohling @crobert-1