Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] fix exhaustive lint for statsd receiver #24046

Merged
merged 1 commit into from
Jul 10, 2023
Merged

[chore] fix exhaustive lint for statsd receiver #24046

merged 1 commit into from
Jul 10, 2023

Conversation

fatsheep9146
Copy link
Contributor

Description:
related #23266

@fatsheep9146 fatsheep9146 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 9, 2023
@fatsheep9146 fatsheep9146 requested review from a team, jmacd and dmitryax as code owners July 9, 2023 11:34
@github-actions github-actions bot added the receiver/statsd statsd related issues label Jul 9, 2023
@fatsheep9146 fatsheep9146 mentioned this pull request Jul 9, 2023
Closed
67 tasks
atoulme
atoulme approved these changes Jul 9, 2023
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fatsheep9146
Copy link
Contributor Author

ping owner for review @dmitryax @jmacd

@dmitryax dmitryax merged commit 4341e10 into open-telemetry:main Jul 10, 2023
92 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 10, 2023
@jmacd jmacd mentioned this pull request Jul 10, 2023
Closed
@jmacd
Copy link
Contributor

jmacd commented Jul 10, 2023

I was asked to review #23888 but this has already merged. Anyway the changes don't look very correct.

codeboten pushed a commit to codeboten/opentelemetry-collector-contrib that referenced this pull request Jul 10, 2023
[receiver/statsd] fix linting changes
8c1092f 
There were changes in behaviour introduced in open-telemetry#24046 which
needed to be fixed to maintain current receiver behaviour.

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten mentioned this pull request Jul 10, 2023
Merged
codeboten pushed a commit that referenced this pull request Jul 10, 2023
[receiver/statsd] fix linting changes (#24162)
7abb7f8 
There were changes in behaviour introduced in
#24046
which needed to be fixed to maintain current receiver behaviour.

---------

Signed-off-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@dmitryax dmitryax dmitryax approved these changes

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

Assignees

@atoulme atoulme

Labels
receiver/statsd statsd related issues Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.82.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fatsheep9146 @jmacd @atoulme @dmitryax