Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Move config validation into validate function #24015

Merged
merged 1 commit into from
Jul 7, 2023
Merged

[chore] Move config validation into validate function #24015

merged 1 commit into from
Jul 7, 2023

Conversation

djaglowski
Copy link
Member

These validation rules should always apply. This minor cleanup will help with a future PR that simplifies initialization of the Manager.

@djaglowski djaglowski marked this pull request as ready for review July 6, 2023 16:14
@djaglowski djaglowski requested a review from a team as a code owner July 6, 2023 16:14
@djaglowski djaglowski requested a review from songy23 July 6, 2023 16:14
@djaglowski djaglowski merged commit d3f5cd4 into open-telemetry:main Jul 7, 2023
92 checks passed
@djaglowski djaglowski deleted the fileconsumer-validate branch July 7, 2023 08:33
@github-actions github-actions bot added this to the next release milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

@songy23 songy23 Awaiting requested review from songy23 songy23 is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@fatsheep9146 fatsheep9146

Labels
pkg/stanza
Projects
None yet
Milestone
v0.82.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djaglowski @fatsheep9146