Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/httpcheck] address review comments from #23439 #24002

Merged
merged 2 commits into from
Jul 6, 2023
Merged

[receiver/httpcheck] address review comments from #23439 #24002

merged 2 commits into from
Jul 6, 2023

Conversation

srikanthccv
Copy link
Member

Addressing post-merge comments in #23439 from @astencel-sumo

I hope this doesn't require a CHANGELOG.

@srikanthccv srikanthccv requested review from a team and codeboten as code owners July 6, 2023 01:58
@github-actions github-actions bot added the receiver/httpcheck HTTP Check receiver label Jul 6, 2023
andrzej-stencel
andrzej-stencel approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrzej-stencel andrzej-stencel added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 6, 2023
@andrzej-stencel
Copy link
Member

Looks like you need to run make lint on the module @srikanthccv https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5470737506/jobs/9961168962?pr=24002

codeboten
codeboten approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srikanthccv for addressing these and thanks @astencel-sumo for raising them

@codeboten codeboten merged commit f3e4755 into open-telemetry:main Jul 6, 2023
88 of 89 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 6, 2023
@srikanthccv srikanthccv deleted the httpcheck-review-fixes branch July 6, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

Assignees

@kovrus kovrus

Labels
receiver/httpcheck HTTP Check receiver Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.82.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@srikanthccv @andrzej-stencel @codeboten @kovrus