[chore] fix exhaustive lint for attribute processor #23942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ziqi Zhao <[email protected]>
fatsheep9146
added
the
Skip Changelog
67 tasks
djaglowski
approved these changes
Jul 5, 2023
|
@fatsheep9146, there is one more switch with missing cases |
codeboten
reviewed
Jul 5, 2023
There was a problem hiding this comment.
Error: k8sattributesprocessor/processor.go:214:2: missing cases in switch of type pcommon.ValueType: pcommon.ValueTypeEmpty, pcommon.ValueTypeDouble, pcommon.ValueTypeBool, pcommon.ValueTypeMap, pcommon.ValueTypeSlice, pcommon.ValueTypeBytes (exhaustive)
level=info msg="File cache stats: 25 entries of total size 231.9KiB"
level=info msg="Memory: 1074 samples, avg is 254.8MB, max is 977.7MB"
level=info msg="Execution took 1m57.741780707s"
switch val.Type() {
^
Error: k8sattributesprocessor/internal/kube/client.go:757:3: missing cases in switch of type selection.Operator: selection.DoesNotExist, selection.DoubleEquals, selection.In, selection.NotIn, selection.Exists, selection.GreaterThan, selection.LessThan (exhaustive)
switch f.Op {
^
make[2]: *** [../../Makefile.Common:167: lint] Error 1
Signed-off-by: Ziqi Zhao <[email protected]>
Solved @codeboten please help review again |
djaglowski
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
related #23266