Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatgen] add redhat distro hint #23603

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented Jun 21, 2023

Description:

Adds references to the OpenShift OpenTelemetry distro provided by redhat.

Link to tracking Issue:

Testing:

Documentation:

Signed-off-by: Benedikt Bongartz <[email protected]>
@frzifus
Copy link
Member Author

frzifus commented Jun 21, 2023

hm.. I assume this k8s test is just flaky.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you add a description to the PR?

@mx-psi
Copy link
Member

mx-psi commented Jun 21, 2023

Looks like you also need to make generate

Signed-off-by: Benedikt Bongartz <[email protected]>
@frzifus
Copy link
Member Author

frzifus commented Jun 21, 2023

done 👍

@codeboten codeboten merged commit 4b0fe71 into open-telemetry:main Jun 21, 2023
88 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 21, 2023
@frzifus frzifus deleted the add_redhat_distro_hint branch June 21, 2023 15:58
fchikwekwe pushed a commit to fchikwekwe/opentelemetry-collector-contrib that referenced this pull request Jun 23, 2023
Adds references to the OpenShift OpenTelemetry distro provided by
redhat.

---------

Signed-off-by: Benedikt Bongartz <[email protected]>
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
Adds references to the OpenShift OpenTelemetry distro provided by
redhat.

---------

Signed-off-by: Benedikt Bongartz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants