Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] [cmd/mdatagen] Remove unused (md *metadata) Unmarshal func #23575

Merged
merged 1 commit into from
Jun 20, 2023
Merged

[chore] [cmd/mdatagen] Remove unused (md *metadata) Unmarshal func #23575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
mdatagen: Remove unused (md *metadata) Unmarshal func 
This func is not used. Because the receiver is the metadata struct, it would need to be called directly.

This also tests field Name -- which does not exist anymore (replaced by Type).

**Note:** Validation of Type will be done as part of #23424
  • Loading branch information
@mackjmr
mackjmr committed Jun 20, 2023
commit e8a2feaddbf60c2ab5c929b650e518f558f7b55e
11 changes: 0 additions & 11 deletions cmd/mdatagen/loader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,17 +224,6 @@ type metadata struct {
ScopeName string `mapstructure:"-"`
}

func (md *metadata) Unmarshal(parser *confmap.Conf) error {
if !parser.IsSet("name") {
return errors.New("missing required field: `description`")
}
err := parser.Unmarshal(md, confmap.WithErrorUnused())
if err != nil {
return err
}
return nil
}

func (md *metadata) Validate() error {
var errs error

Expand Down
Loading