Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about security documentation to exporter README #2341

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

flands
Copy link
Contributor

@flands flands commented Feb 13, 2021

Attempts to address #2230, #2231, #2232, #2233

@flands flands requested review from dmitryax, owais and a team as code owners February 13, 2021 22:18
@project-bot project-bot bot added this to In progress in Collector Feb 13, 2021
@flands
Copy link
Contributor Author

flands commented Feb 13, 2021

@mx-psi @arminru @gramidt @alolita FYI

@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #2341 (41e45ba) into main (723ee26) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2341   +/-   ##
=======================================
  Coverage   90.62%   90.63%           
=======================================
  Files         404      404           
  Lines       20012    20012           
=======================================
+ Hits        18135    18137    +2     
+ Misses       1417     1416    -1     
+ Partials      460      459    -1     
Flag Coverage Δ
integration 69.33% <ø> (+0.06%) ⬆️
unit 89.45% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
receiver/k8sclusterreceiver/watcher.go 97.64% <0.00%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 723ee26...41e45ba. Read the comment docs.

Copy link
Member

@gramidt gramidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! . On a related note, I started a discussion for integration with external secret stores and systems here: open-telemetry/opentelemetry-collector#2469 .

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, would like to know @alolita's thoughts on this :)

Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @flands!

Collector automation moved this from In progress to Reviewer approved Feb 16, 2021
@bogdandrutu
Copy link
Member

bogdandrutu commented Feb 16, 2021

@alolita if you have any concerns please file an issue and will address.

@bogdandrutu bogdandrutu merged commit e7415d7 into open-telemetry:main Feb 16, 2021
Collector automation moved this from Reviewer approved to Done Feb 16, 2021
@flands flands deleted the flands/apikey branch February 17, 2021 03:30
kisieland referenced this pull request in kisieland/opentelemetry-collector-contrib Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants