Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Rename test helper func in fileconsumer package #23251

Merged

Conversation

djaglowski
Copy link
Member

We don't need to specify "WithOptions" in the function name, as the options are optional.

@djaglowski djaglowski force-pushed the fileconsumer-rename-testhelper branch from 0104017 to 7b3ec56 Compare June 9, 2023 15:51
@djaglowski djaglowski marked this pull request as ready for review June 9, 2023 16:37
@djaglowski djaglowski requested review from a team and dmitryax June 9, 2023 16:37
@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Jun 9, 2023
@djaglowski djaglowski merged commit b05f676 into open-telemetry:main Jun 9, 2023
@djaglowski djaglowski deleted the fileconsumer-rename-testhelper branch June 9, 2023 17:52
@github-actions github-actions bot added this to the next release milestone Jun 9, 2023
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/stanza ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants