[pkg/translator/prometheus] Switch NormalizeName FG back to alpha
#23229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
requested review from
a team,
Aneurysm9,
dashpole and
kovrus
as code owners
github-actions
bot
added
exporter/prometheus
pkg/translator/prometheus
receiver/prometheus
Disable `pkg.translator.prometheus.NormalizeName` feature gate by default The feature gate `pkg.translator.prometheus.NormalizeName` was enabled prematurely while translation on the prometheus receiver was incomplete. To address this, the feature gate has been reverted back to alpha status. This will remain the case until the translation on the receiver side aligns with the translation on the exporter side, or until it is replaced with a configuration option or completely removed. To maintain the current behavior, you can enable the feature gate using the `--feature-gates=pkg.translator.prometheus.NormalizeName` command argument. However, please note that the translation in the prometheus receiver is a subject to future changes.
dmitryax
force-pushed
the
disable-prom-feature-gate
branch
from
56cfcc9
to
08386c2
Compare
songy23
approved these changes
Jun 8, 2023
kovrus
approved these changes
Jun 8, 2023
codeboten
approved these changes
Jun 8, 2023
hdkshingala
added a commit
to fluxninja/opentelemetry-collector-contrib
that referenced
this pull request
Jul 4, 2023
… alpha (open-telemetry#23229)" This reverts commit 47b208f.
hdkshingala
added a commit
to fluxninja/opentelemetry-collector-contrib
that referenced
this pull request
Jul 4, 2023
… alpha (open-telemetry#23229)" This reverts commit 47b208f.
Caleb-Hurshman
pushed a commit
to observIQ/opentelemetry-collector-contrib
that referenced
this pull request
Jul 6, 2023
…pen-telemetry#23229) Disable `pkg.translator.prometheus.NormalizeName` feature gate by default The feature gate `pkg.translator.prometheus.NormalizeName` was enabled prematurely while translation on the prometheus receiver was incomplete. To address this, the feature gate has been reverted back to alpha status. This will remain the case until the translation on the receiver side aligns with the translation on the exporter side, or until it is replaced with a configuration option or completely removed. To maintain the current behavior, you can enable the feature gate using the `--feature-gates=pkg.translator.prometheus.NormalizeName` command argument. However, please note that the translation in the prometheus receiver is a subject to future changes.
jmichalak-fluxninja
pushed a commit
to fluxninja/opentelemetry-collector-contrib
that referenced
this pull request
Aug 9, 2023
… alpha (open-telemetry#23229)" This reverts commit 47b208f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable
pkg.translator.prometheus.NormalizeNamefeature gate by defaultThe feature gate
pkg.translator.prometheus.NormalizeNamewas enabled prematurely while translation in the prometheus receiver was incomplete. To address this, the feature gate has been reverted back to alpha status. This will remain the case until the translation on the receiver side aligns with the translation on the exporter side or until it is replaced with a configuration option. To maintain the current behavior, you can enable the feature gate using the--feature-gates=pkg.translator.prometheus.NormalizeNamecommand argument. However, please note that the translation in the prometheus receiver is a subject to future changes.This is mostly a revert of #20519
Link to tracking Issue: #23208