[processor/websocket] Implementation of websocket processor #23053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
websocketprocessor_impl
branch
2 times, most recently
from
1ff1247
to
6c212cf
Compare
|
I've left a comment on the issue regarding the name since we can it would be nice to make it clearer the intent of the processor. |
|
Thanks @MovieStoreGuy that's something we would want to deal with in a subsequent PR if possible. Agree it might not reflect the intent of the processor best right now. |
dmitryax
reviewed
Jun 7, 2023
atoulme
force-pushed
the
websocketprocessor_impl
branch
from
41709e7
to
49d6711
Compare
dmitryax
approved these changes
Jun 8, 2023
|
PTAL at the CI failures |
atoulme
force-pushed
the
websocketprocessor_impl
branch
from
dd5d78c
to
73e000d
Compare
|
Look like |
atoulme
force-pushed
the
websocketprocessor_impl
branch
from
73e000d
to
cda7b28
Compare
Caleb-Hurshman
pushed a commit
to observIQ/opentelemetry-collector-contrib
that referenced
this pull request
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implementation of the websocket processor
Link to tracking Issue:
#19633
Testing:
Unit tests
Documentation:
N/A