Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] better formatting for connector READMEs #23036

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

mwear
Copy link
Member

@mwear mwear commented Jun 2, 2023

Description:
mdatagen was recently updated to generate portions of the connector READMEs, but could benefit from some additional line breaks. This PR adds 2. At least one was requested here: #23017 (comment).

Testing:
I've regenerated the relevant readmes in this PR. Take a look and let me know if any additional formatting should be addressed.

cc: @dmitryax

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need a rebase to update the servicegraph connector as well

@github-actions github-actions bot requested a review from mapno June 2, 2023 16:05
@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 2, 2023
@djaglowski djaglowski added the ready to merge Code review completed; ready to merge by maintainers label Jun 2, 2023
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mwear!

@djaglowski djaglowski merged commit 3d221b7 into open-telemetry:main Jun 2, 2023
@github-actions github-actions bot added this to the next release milestone Jun 2, 2023
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
)

[mdatagen] better formatting for connector readmes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/mdatagen mdatagen command connector/count connector/servicegraph connector/spanmetrics ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants