[chore] more linting fixes #22979
Merged
[chore] more linting fixes #22979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostly changes are unused parameters. a couple of them are false positives on empty for loops that i added a nolint to. there's also a redundant if and a couple of non-wrapping format verb issues fixed Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
songy23
reviewed
May 31, 2023
Co-authored-by: Yang Song <[email protected]>
Co-authored-by: Yang Song <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
songy23
approved these changes
May 31, 2023
Caleb-Hurshman
pushed a commit
to observIQ/opentelemetry-collector-contrib
that referenced
this pull request
Jul 6, 2023
* [chore] more linting fixes mostly changes are unused parameters. a couple of them are false positives on empty for loops that i added a nolint to. there's also a redundant if and a couple of non-wrapping format verb issues fixed --------- Signed-off-by: Alex Boten <[email protected]> Co-authored-by: Yang Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly changes are unused parameters. a couple of them are false positives on empty for loops that i added a nolint to. there's also a redundant if and a couple of non-wrapping format verb issues fixed