fix(awscloudwatchreceiver): emit logs from one stream in one resource #22976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboguszewski-sumo
force-pushed
the
cloudwatch-fix
branch
2 times, most recently
from
e54f7a4
to
93e893a
Compare
djaglowski
reviewed
Jun 7, 2023
aboguszewski-sumo
force-pushed
the
cloudwatch-fix
branch
from
93e893a
to
6d4512d
Compare
6 tasks
djaglowski
reviewed
Jun 23, 2023
|
Sorry that it took so long, but I fixed these issues now. |
aboguszewski-sumo
force-pushed
the
cloudwatch-fix
branch
from
cd8d4f0
to
25b6c83
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@djaglowski this got marked as stale and is ready to review |
djaglowski
reviewed
Jul 20, 2023
djaglowski
approved these changes
Jul 20, 2023
Co-authored-by: Daniel Jaglowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The receiver treated every event as a separate log. However, it makes a lot sense to group logs into common resource by their group and stream. Logs without a stream are grouped into the same resource.
I'm not sure how should
scopebe treated here, but my intuition tells me that it makes sense to group them also into the same scope.Link to tracking Issue:
Fixes #22145
Testing:
The unit test for the receiver has beed updated. Note that the events in
prefixed.yamlare the same, but differ by their id - I found it simpler to do than creating different events.