Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/stanza/fileconsumer] Fix issue where empty files caused errors #22945

Merged
merged 1 commit into from
Jun 5, 2023
Merged

[pkg/stanza/fileconsumer] Fix issue where empty files caused errors #22945

merged 1 commit into from
Jun 5, 2023

Conversation

djaglowski
Copy link
Member

Resolves #22815

@djaglowski djaglowski marked this pull request as ready for review May 30, 2023 16:08
@djaglowski djaglowski requested review from a team and dashpole May 30, 2023 16:08
crobert-1
crobert-1 approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested locally and the issue has been resolved. Thanks for fixing!

@dmitryax
Copy link
Member

dmitryax commented Jun 5, 2023

@djaglowski @codeboten are you ok with merging this PR?

@djaglowski
Copy link
Member Author

I think we should merge.

@codeboten codeboten merged commit dc90ec9 into open-telemetry:main Jun 5, 2023
@djaglowski djaglowski deleted the filelog-close-empty-err branch June 5, 2023 18:57
@github-actions github-actions bot added this to the next release milestone Jun 5, 2023
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
@djaglowski @Caleb-Hurshman
[pkg/stanza/fileconsumer] Fix issue where empty files caused errors (o…
7603472 
…pen-telemetry#22945)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@dmitryax dmitryax dmitryax approved these changes

@codeboten codeboten codeboten approved these changes

@crobert-1 crobert-1 crobert-1 approved these changes

@dashpole dashpole Awaiting requested review from dashpole

Assignees

@bogdandrutu bogdandrutu

Labels
pkg/stanza
Projects
None yet
Milestone
v0.79.0
Development

Successfully merging this pull request may close these issues.

[receiver/filelog] Empty file already closed
6 participants
@djaglowski @dmitryax @atoulme @codeboten @crobert-1 @bogdandrutu