Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable spanmetricsprocessor component #2225

Merged

Conversation

albertteoh
Copy link
Contributor

@albertteoh albertteoh commented Jan 29, 2021

Signed-off-by: albertteoh [email protected]

Description: Enables the spanmetricsprocessor for use in otel collector configs as a follow-up to #2012.

Link to tracking Issue: Fixes #403

Testing: Integration tested locally against a prebuilt Grafana dashboard to confirm metrics look correct.

@albertteoh albertteoh requested a review from a team as a code owner January 29, 2021 01:42
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #2225 (075f2fa) into main (8ca2e9b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2225   +/-   ##
=======================================
  Coverage   90.52%   90.52%           
=======================================
  Files         397      397           
  Lines       19689    19690    +1     
=======================================
+ Hits        17824    17825    +1     
  Misses       1405     1405           
  Partials      460      460           
Flag Coverage Δ
integration 69.26% <0.00%> (-0.11%) ⬇️
unit 89.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/otelcontribcol/components.go 87.01% <100.00%> (+0.17%) ⬆️
processor/spanmetricsprocessor/processor.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca2e9b...075f2fa. Read the comment docs.

@albertteoh
Copy link
Contributor Author

@tigrannajaryan this should be the last PR for #403.

@tigrannajaryan tigrannajaryan merged commit 72abe50 into open-telemetry:main Jan 29, 2021
@tigrannajaryan
Copy link
Member

@albertteoh thank you.

dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
@albertteoh albertteoh deleted the enable-spanmetricsprocessor branch January 30, 2021 09:46
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
Signed-off-by: albertteoh <[email protected]>

**Description:** Enables the spanmetricsprocessor for use in otel collector configs as a follow-up to #2012.

**Link to tracking Issue:** Fixes #403

**Testing:** Integration tested locally against a prebuilt Grafana dashboard to confirm metrics look correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Span Stats processor
3 participants