Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Add observIQ distribution to component READMEs #22047

Merged
merged 1 commit into from
May 17, 2023
Merged

[chore] Add observIQ distribution to component READMEs #22047

merged 1 commit into from
May 17, 2023

Conversation

djaglowski
Copy link
Member

No description provided.

@atoulme
Copy link
Contributor

atoulme commented May 17, 2023

LGTM, feel free to use alphabetical order for the distros? Or don't worry about it, and mdatagen down the road can sort alphabetically.

@atoulme
Copy link
Contributor

atoulme commented May 17, 2023

I see it now - aws was not in alphabetical order. OK, we can figure this out separately from this PR.

@djaglowski
Copy link
Member Author

Yeah, I considered alphabetical, but thought core and contrib should appear first and second respectively. Maybe those are hardcoded and then alphabetize the rest? As you said, we can decide in mdatagen.

@djaglowski djaglowski marked this pull request as ready for review May 17, 2023 18:20
@djaglowski djaglowski requested a review from a team May 17, 2023 18:20
@djaglowski djaglowski requested a review from a team May 17, 2023 18:20
@dmitryax
Copy link
Member

dmitryax commented May 17, 2023 •
edited
Loading

Yeah, I considered alphabetical, but thought core and contrib should appear first and second respectively. Maybe those are hardcoded and then alphabetize the rest? As you said, we can decide in mdatagen.

core+contrib and rest in alphabetic order is what we agreed on in #21383

@djaglowski djaglowski merged commit fdef6f5 into open-telemetry:main May 17, 2023
@djaglowski djaglowski deleted the ref-observiq-dist branch May 17, 2023 18:27
@github-actions github-actions bot added this to the next release milestone May 17, 2023
@atoulme
Copy link
Contributor

atoulme commented May 17, 2023

We will make mdatagen output distro links in the right order. I have opened #22051 to follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@songy23 songy23 songy23 approved these changes

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@kovrus kovrus Awaiting requested review from kovrus

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@arminru arminru Awaiting requested review from arminru

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

Assignees

@mx-psi mx-psi

Labels
cmd/mdatagen mdatagen command exporter/alibabacloudlogservice Alibaba components exporter/awscloudwatchlogs awscloudwatchlogs exporter exporter/awsemf awsemf exporter exporter/awskinesis exporter/awss3 exporter/awsxray exporter/azuremonitor exporter/carbon exporter/coralogix exporter/datadog Datadog components exporter/dynatrace exporter/elasticsearch exporter/f5cloud F5 exporter exporter/file exporter/googlecloud exporter/googlecloudpubsub exporter/googlemanagedprometheus Google Managed Prometheus exporter exporter/influxdb exporter/kafka exporter/loadbalancing exporter/logzio exporter/loki Loki Exporter exporter/opencensus exporter/prometheus exporter/prometheusremotewrite exporter/sapm exporter/signalfx exporter/splunkhec exporter/zipkin extension/basicauth extension/bearertokenauth extension/healthcheck Health Check Extension extension/oidcauth extension/pprof extension/storage processor/attributes Attributes processor processor/cumulativetodelta Cumulative To Delta processor processor/deltatorate Delta To Rate processor processor/filter Filter processor processor/groupbyattrs Group By Attributes processor processor/groupbytrace Group By Trace processor processor/k8sattributes k8s Attributes processor processor/logstransform Logs Transform processor processor/metricstransform Metrics Transform processor processor/probabilisticsampler Probabilistic Sampler processor processor/resource Resource processor processor/resourcedetection Resource detection processor processor/routing Routing processor processor/span processor/spanmetrics Span Metrics processor processor/tailsampling Tail sampling processor processor/transform Transform processor receiver/activedirectoryds receiver/aerospike receiver/apache receiver/awscloudwatch receiver/awscontainerinsight receiver/awsecscontainermetrics receiver/awsfirehose receiver/awsxray receiver/azureeventhub receiver/bigip receiver/carbon receiver/cloudflare
Projects
None yet
Milestone
v0.78.0
Development

Successfully merging this pull request may close these issues.
5 participants
@djaglowski @atoulme @dmitryax @songy23 @mx-psi