Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add go.work to gitignore #21972

Merged

Conversation

codeboten
Copy link
Contributor

No description provided.

@codeboten codeboten requested review from a team and mx-psi May 15, 2023 20:01
@dmitryax
Copy link
Member

dmitryax commented May 15, 2023

Looking at golang/go#53502, it seems beneficial to keep it in repos with many interdependent modules... Why do we want to exclude before trying?

@codeboten
Copy link
Contributor Author

Looking at golang/go#53502, it seems beneficial to keep it in repos with many interdependent modules... Why do we want to exclude before trying?

I use go work locally and keep avoiding checking those files in, as i was under the impression the correct thing to do was to not check those in. I'm ok with replacing this PR w/ one that checks them in, I really just want a clean local repo 😄

@dmitryax
Copy link
Member

SGTM, do we still want to adopt the workspaces and update all the make targets to use it?

@codeboten
Copy link
Contributor Author

SGTM, do we still want to adopt the workspaces and update all the make targets to use it?

I've not found a way to successfully use workspaces for purposes other than making intellisense happy :D in other words, i'm not sure if there is much to be gained by updating make targets at this point in time.

@codeboten codeboten merged commit d6d9886 into open-telemetry:main May 16, 2023
@codeboten codeboten deleted the codeboten/add-work-to-ignore branch May 16, 2023 00:24
@github-actions github-actions bot added this to the next release milestone May 16, 2023
@mx-psi
Copy link
Member

mx-psi commented May 16, 2023

@pellared is working on making crosslink update and understand go.work (see open-telemetry/opentelemetry-go-build-tools/pull/311). We may want to revert this PR once that work is completed.

@pellared
Copy link
Member

After playing with Go workspaces for a while I think it is safer to keep go.work and go.work.sum in Git ignore. The go toolchain works a little different. Because Go workspaces are not widely adopted we may encounter bugs (example: golang/go#60126). Therefore I think it is better to make sure that CI does not work with Go workspaces.

PS. I initially wanted to commit go.work as well 😉

CC @mx-psi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants