Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Switch to codeql job to run on macos to have more resources #21818

Merged
merged 1 commit into from
May 11, 2023

Conversation

TylerHelmuth
Copy link
Member

Description:
Updates the codeql job to run on macos instead of ubuntu in order to take advantage of the increased resources the macos runners provide.

image

I tested this in my fork and while the job still takes about 30 minutes, I never saw it fail. It produced the same results as the current job. I propose we try it out and if it doesn't actually solve the problem we revert.

Link to tracking Issue:

#19393

Testing:
Here is one of the runs: https://github.com/TylerHelmuth/opentelemetry-collector-contrib/actions/runs/4939630224

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner May 11, 2023 15:59
@TylerHelmuth TylerHelmuth requested a review from kovrus May 11, 2023 15:59
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is possible, can the codeql job be run on groups as we do other longer jobs?

@TylerHelmuth
Copy link
Member Author

groups as we do other longer jobs

Yes, I believe instead of doing make otelcontribcol we could individually build each component. We might need to do that anyways to make the reported results better (see issue for the concern on the results). For now, though, I think this PR can give us the green check we want on commits as we continue to make improvements.

@codeboten codeboten merged commit 7d65814 into open-telemetry:main May 11, 2023
@github-actions github-actions bot added this to the next release milestone May 11, 2023
@codeboten
Copy link
Contributor

@TylerHelmuth opened #21823 to follow up

@TylerHelmuth TylerHelmuth deleted the fix-codeql branch May 11, 2023 16:49
varunraiko pushed a commit to varunraiko/opentelemetry-collector-contrib that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants