[receiver/nginx] Add featuregate to emit 'nginx.connections_current' as a non-monotonic sum #21686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
nginx-connections-sum
branch
2 times, most recently
from
d72b819
to
98a3d5b
Compare
…as a non-monotonic sum The featuregate is called 'receiver.nginx.emitConnectionsCurrentAsSum'. Since the intended change involves emitting a metric with a different data type, it was necessary to temporarily introduce a dummy metric that could be swapped in place when the gate is enabled. This metric is never actually emitted, but it does appear in autogenerated documentation.
djaglowski
force-pushed
the
nginx-connections-sum
branch
from
98a3d5b
to
b3e919f
Compare
mx-psi
approved these changes
May 10, 2023
varunraiko
pushed a commit
to varunraiko/opentelemetry-collector-contrib
that referenced
this pull request
May 17, 2023
…as a non-monotonic sum (open-telemetry#21686) The featuregate is called 'receiver.nginx.emitConnectionsCurrentAsSum'. Since the intended change involves emitting a metric with a different data type, it was necessary to temporarily introduce a dummy metric that could be swapped in place when the gate is enabled. This metric is never actually emitted, but it does appear in autogenerated documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The featuregate is called
receiver.nginx.emitConnectionsCurrentAsSum.Since the intended change involves emitting the same metric with a different data type, it was necessary to temporarily introduce a dummy metric that could be swapped in place when the gate is enabled. This dummy metric is never actually emitted with its dummy name or description, but it does appear in autogenerated documentation.
Updates #4326